Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autostop loop #1262

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Update autostop loop #1262

merged 2 commits into from
Sep 17, 2024

Conversation

carolineechen
Copy link
Collaborator

@carolineechen carolineechen commented Sep 16, 2024 •
edited
Loading

  • don't permanently break out of the while loop when initial conditions arent met (interval size could potentially be adjusted)
  • remove redundant checks
  • update autostop at beginning of loop (may be better split out of the status loop in the future)

@carolineechen Graphite App
Copy link
Collaborator Author

carolineechen commented Sep 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

@carolineechen carolineechen mentioned this pull request Sep 16, 2024
Merged
@carolineechen carolineechen force-pushed the cc/autostop-tests branch 3 times, most recently from b51fea5 to d182ed5 Compare September 17, 2024 04:57
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 17, 2024

Joe Biden Snl GIF by Saturday Night Live (Added via Giphy)

Base automatically changed from cc/autostop-tests to main September 17, 2024 20:24
@carolineechen carolineechen merged commit d41bece into main Sep 17, 2024
11 of 13 checks passed
@carolineechen carolineechen deleted the cc/autostop-loop branch September 17, 2024 20:24
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 17, 2024

Graphite Automations

"rohin" took an action on this PR • (09/17/24)

1 gif was posted to this PR based on Rohin Bhasin's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohinb2 rohinb2 rohinb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolineechen @rohinb2