Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate system arg from function/module factory functions #625

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

carolineechen
Copy link
Collaborator

previously, specifying system in factory function would send the function/module to the system upon construction. this behavior was updated recently to support constructing a function/module object that already lives on the cluster, such that the object's system attribute was being set but nothing was being sent. however, this is confusing for cases like rh.function(local_fn, system=remote_cluster), as no action is done and the function lives locally.

for clarity, force users to use .to(system) for sending function code to a cluster. or .from_name or rh.function(name="name") for reloading existing function/module that lives remotely.

Copy link
Collaborator Author

carolineechen commented Mar 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

Base automatically changed from cc/del-deprecations to main March 19, 2024 21:16
@carolineechen carolineechen force-pushed the cc/deprecate-system branch 3 times, most recently from 8517e04 to c32ac0a Compare March 20, 2024 17:01
@carolineechen carolineechen merged commit bfbe901 into main Mar 20, 2024
11 checks passed
@carolineechen carolineechen deleted the cc/deprecate-system branch March 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant