Deprecate system arg from function/module factory functions #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, specifying system in factory function would send the function/module to the system upon construction. this behavior was updated recently to support constructing a function/module object that already lives on the cluster, such that the object's system attribute was being set but nothing was being sent. however, this is confusing for cases like
rh.function(local_fn, system=remote_cluster)
, as no action is done and the function lives locally.for clarity, force users to use
.to(system)
for sending function code to a cluster. or.from_name
orrh.function(name="name")
for reloading existing function/module that lives remotely.