Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny performance improvments #685

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Tiny performance improvments #685

merged 1 commit into from
Apr 2, 2024

Conversation

dongreenberg
Copy link
Contributor

@dongreenberg dongreenberg commented Apr 1, 2024

TL;DR

This PR decreases the LOGGING_WAIT_TIME to .5 from 1 and increases max_concurrency from 1000 to 10,000 in both get_cluster_servlet and get_env_servlet functions at obj_store.py.

What changed?

  • The LOGGING_WAIT_TIME constant in the constants.py file has been decreased to .5 from 1.
  • The max_concurrency parameter in both get_cluster_servlet and get_env_servlet functions in the obj_store.py file has been increased from 1000 to 10,000.
  • The logging of GET call parameters in the get_call function in http_server.py file has been removed.

Why make this change?

This change is made to increase the server's concurrent handling capacity and to make the logging output more efficient by reducing the wait time. It also removes redundant logging.


Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dongreenberg and the rest of your teammates on Graphite Graphite

@dongreenberg dongreenberg marked this pull request as ready for review April 1, 2024 15:35
@dongreenberg dongreenberg force-pushed the small_perf_improvements branch 3 times, most recently from e45b1bc to a7ca15f Compare April 2, 2024 00:12
@dongreenberg dongreenberg merged commit 6e23f92 into main Apr 2, 2024
21 checks passed
@dongreenberg dongreenberg deleted the small_perf_improvements branch April 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant