Switch --directory => --definition flag #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radumereuta
approved these changes
May 5, 2022
There was a problem hiding this comment.
I would like it if we kept the *-kompiled termination as a convention.
- It has a strong visual cue to tell you that it's the directory generated by kompile.
- it's easy to add to .gitignore
- it's easy to remove/make clean
But feel free to merge if you have reasons not to though.
| tests/specs/opcodes/evm-optimizations-spec/haskell/evm-optimizations-spec-kompiled/timestamp \ | ||
| tests/specs/opcodes/verification/java/verification-kompiled/timestamp | ||
| provex_definitions := \ | ||
| tests/specs/benchmarks/functional-spec/haskell/timestamp \ |
There was a problem hiding this comment.
Maybe:
tests/specs/benchmarks/functional-spec/haskell-kompiled/timestamp
There was a problem hiding this comment.
No I disagree, I do not want to encourage anything that lets directory structure be a convention or "magic" for real-world semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: #1240Fortunately KEVM was already using a unique wrapper directory for every definition it
kompiled anyway, so this only needs us to remove references to teh*-kompileddirectories (instead preferring the unique wrapper directory for every definition), and to switch to using the--definitionflag everywhere.