Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement firefly_setNetworkId web3 method #773

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Implement firefly_setNetworkId web3 method #773

merged 4 commits into from
Apr 14, 2020

Conversation

anvacaru
Copy link
Contributor

@anvacaru anvacaru requested a review from ehildenb April 14, 2020 11:15
ehildenb
ehildenb approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@rv-jenkins rv-jenkins merged commit c72eba3 into master Apr 14, 2020
@rv-jenkins rv-jenkins deleted the console_args branch April 14, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehildenb ehildenb ehildenb approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anvacaru @ehildenb @rv-jenkins