-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve source-mapping #808
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add an example of how the result of this change looks like to the issue description? E.g., an updated section in the KCFG view.
src/kontrol/foundry.py
Outdated
return self.solidity_src_print(Path(node.source.name), start_line - 1, end_line) | ||
except Exception as e: | ||
return [str(e)] | ||
return ['NO DATA 2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about the typo:
return ['NO DATA 2'] | |
return ['NO DATA 2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to add in issue #798 an example of how the source mapping is working after these changes?
This PR imports Simbolik approach to source map bytecode into solidity code.
Fixes #798.