Changes when adding strings and images #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Allen <jared@redcact.us>
Signed-off-by: Jared Allen <jared@redcact.us>
- added kImageAboveLabel config to set if images should be display above or too the left of titleLabels. - added kImageTitlePadding config to set the padding between images and titleLabels in either configuration mentioned above. Signed-off-by: Jared Allen <jared@redcact.us>
Signed-off-by: Jared Allen <jared@redcact.us>
… in Popover with title. For some reason the buttons frames were being resized past the Popover bounds causing issues with text alignment. Now all UIButtons are resized to the full width of the Popover view and text alignment is handled by the UIButton. Signed-off-by: Jared Allen <jared@redcact.us>
Signed-off-by: Jared Allen <jared@redcact.us>
|
Hey man, sorry for the long wait! I suck at responding to these... Since there have been a couple of changes since you submitted this, I just merged by hand. Mind giving it a sanity check before I merge into master? https://github.com/runway20/PopoverView/tree/jallen-buttons-with-icons |
|
This works if you just want an images above labels. And it's also missing support for kImageAboveLabel in the config file so images can be rendered to the left of the label. If you want and can rebase and create a new pull request with the latest master. It's up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took another stab at this by creating a branch instead of using my forked master (git noob here).
I also found a weird bug that was causing buttons with just text in a titled Popover to be resized past the width of the popover. Take a look at commit bfe1db9 for more info.
Changes: