-
Notifications
You must be signed in to change notification settings - Fork 52
Reintroduce Schemars with MSRV compatible deps #117
Conversation
675fb35
to
a47bc10
Compare
This reverts commit 4665e8d.
I'm getting
My script simply does #!/bin/sh
set -e
MSRV="1.29.0"
CMD="rustup run ${MSRV}"
rm -f Cargo.lock
$CMD cargo generate-lockfile
$CMD cargo update --package "serde_json" --precise "1.0.39"
$CMD cargo test
$CMD cargo test --features "serde" |
yeah was just fixing that; sorry for the line noise here... |
I think this probably won't work for 1.29 as I didn't realize the cargo edition flag would be a blocker. if we bump to 1.39 or something given the mrustc update, then groovy, otherwise will extract tests into a new crate. |
Closing. Can re-open if we revisit MSRV. |
@apoelstra are you not ok with the tests in separate crate version? The schemars patches themselves worth with current MSRV I think? |
Ok, I'll leave this open -- will review if you can get CI to pass. |
Introduced an extended tests directory of crates which only runs on stable or beta, not 1.29. This removes jsonschema-valid dependencies, and makes bitcoin_hashes only require Schemars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack 133e97d
Reverts 4665e8d to reintroduce #97
Should be MSRV compatible.