Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Reintroduce Schemars with MSRV compatible deps #117

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

JeremyRubin
Copy link
Contributor

Reverts 4665e8d to reintroduce #97

Should be MSRV compatible.

@JeremyRubin JeremyRubin force-pushed the schemars branch 2 times, most recently from 675fb35 to a47bc10 Compare April 5, 2021 20:17
This reverts commit 4665e8d.
@stevenroose
Copy link
Collaborator

I'm getting

$ ./test-msrv.sh 
error: failed to parse manifest at `/home/steven/code/rust/bitcoin_hashes/Cargo.toml`

Caused by:
  feature `rename-dependency` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["rename-dependency"]` to enable this feature

My script simply does

#!/bin/sh

set -e

MSRV="1.29.0"

CMD="rustup run ${MSRV}"

rm -f Cargo.lock
$CMD cargo generate-lockfile
$CMD cargo update --package "serde_json" --precise "1.0.39"

$CMD cargo test
$CMD cargo test --features "serde"

@JeremyRubin
Copy link
Contributor Author

yeah was just fixing that; sorry for the line noise here...

@JeremyRubin
Copy link
Contributor Author

I think this probably won't work for 1.29 as I didn't realize the cargo edition flag would be a blocker.

if we bump to 1.39 or something given the mrustc update, then groovy, otherwise will extract tests into a new crate.

@apoelstra
Copy link
Member

Closing. Can re-open if we revisit MSRV.

@apoelstra apoelstra closed this Apr 27, 2021
@JeremyRubin
Copy link
Contributor Author

@apoelstra are you not ok with the tests in separate crate version? The schemars patches themselves worth with current MSRV I think?

@apoelstra apoelstra reopened this Apr 27, 2021
@apoelstra
Copy link
Member

apoelstra commented Apr 27, 2021

Ok, I'll leave this open -- will review if you can get CI to pass.

@JeremyRubin
Copy link
Contributor Author

Introduced an extended tests directory of crates which only runs on stable or beta, not 1.29. This removes jsonschema-valid dependencies, and makes bitcoin_hashes only require Schemars.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 133e97d

@apoelstra apoelstra merged commit c7882c0 into rust-bitcoin:master Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants