This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Remove schemars pinning #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
09-05-pinning
branch
from
206e6cb
to
dd24ea0
Compare
tcharding
force-pushed
the
09-05-pinning
branch
5 times, most recently
from
0055281
to
79bb744
Compare
|
I give up for today, I'll try and get a green CI run tomorrow. |
tcharding
force-pushed
the
09-05-pinning
branch
from
79bb744
to
dacceeb
Compare
|
hmmm, extended/schemar tests pass using beta toolchain locally, any ideas why this would fail on CI? |
tcharding
force-pushed
the
09-05-pinning
branch
from
dacceeb
to
bd379c3
Compare
|
Rebased. |
Clippy emits various errors of form: error: this expression borrows a value the compiler would automatically borrow As suggested, remove the unnecessary borrow. FTR, this error shows up because of a clippy update (I believe).
Pinning was introduced using `<=` in the version number for `schemars` and `dyn-clone`, we would prefer to use pinning by way of the `cargo update -p`. - Remove the pinning from `Cargo.toml`. - Add pinning to CI - Document pinning in readme
tcharding
force-pushed
the
09-05-pinning
branch
from
bd379c3
to
edddddc
Compare
|
Includes #187 |
|
Closing in preparation for archiving this repo. See rust-bitcoin/rust-bitcoin#1284 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning was introduced using
<=in the version number forschemarsanddyn-clone, we would prefer to use pinning by way of thecargo update -p.Cargo.toml.Fix: #179
Note
To facilitate pinning this PR changes the package (and directory) name of the schemars test to be
schemar- this is done so that pinning is possible without a naming conflict between theschemarsdependency and the test package name.