-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to serde 1.0 #125
Update to serde 1.0 #125
Conversation
643c7f2
to
b85dedc
Compare
I think upgrading to serde 1.0 might be easier than trying to support both. I believe what needs to be done is:
[*] Ok, yes, the actual modern way is to use |
429095a
to
a1fde2a
Compare
@apoelstra strason 0.4 isn't compiling on 1.14.0 |
Also I've included your secp256k1 changes in this PR. |
a82a792
to
0094709
Compare
Can you rebase now that we have secp 0.10 in? |
0094709
to
b8ad04e
Compare
Done |
src/lib.rs
Outdated
extern crate serde; | ||
extern crate strason; | ||
#[cfg(feature = "serde")] extern crate serde; | ||
#[cfg(any(feature = "serde-decimal", feature = "strason"))] extern crate strason; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this any
isn't needed because serde-decimal
implies strason
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK except for this. I think it can just be #[cfg(feature = "strason")]
The `serde_struct_impl!` macro has been modified to be compatible with the serde 1.0 crate, we use this macro and not the `serde_derive` crate because the latter doesn't support Rust 1.14.0 which is shipped on Debian stable and we should remain compatible with it. Two new features were added: - "serde": enables serialization/deserialization for common types, it pulls the serde 1.0 dependency. - "serde-decimal": enables serialization/deserialization for `UDecimal`/`Decimal`, this pulls the strason 0.4 depdendency and the serde 1.0 dependency. Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
b8ad04e
to
1b4aba1
Compare
Done |
Implement pre allocation context creation
Support for github actions
Status: Ready for review