Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taproot docs nits #923

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Mar 31, 2022

See to nits from review of #912

Three minor patches to the taproot module docs.

CC @dr-orlovsky

Adding a 'the' makes this sentence a little better.
We can help the users by linking them to errors when mentioning them in
the docs.
Further assist devs in understanding the `NodeInfo` struct by adding
docs about when/why the struct is used.
@tcharding tcharding added trivial Obvious, easy and quick to review (few lines or doc-only...) RC fix labels Mar 31, 2022
Copy link
Collaborator

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da731c4

@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Mar 31, 2022
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da731c4

@sanket1729 sanket1729 merged commit efbe141 into rust-bitcoin:master Apr 1, 2022
@tcharding tcharding deleted the taproot-docs-nits branch April 4, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants