This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Added basic failure name #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
reviewed
Dec 29, 2018
src/lib.rs
Outdated
| /// Returns the "name" of the error. | ||
| /// | ||
| /// This is typically the type name. Not all errors will implement | ||
| /// this. |
There was a problem hiding this comment.
I think I'd prefer it if the documentation said something like:
This is typically the type name. It's expected to be most useful in situations where errors need to be reported to external systems.
davidbarsky
approved these changes
Dec 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.