Add 128 bit integers #1364
Merged
Add 128 bit integers #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just came across this #1230 where it says since 128 bit support is a new feature it should go into appendix and not on chapter 3. Feel free to decline this PR if it doesn't need to be included in the table. |
|
The rules have changed since then, this is actually exactly what's supposed to happen. Sorry about the confusion here! |
steveklabnik
approved these changes
May 16, 2018
|
Thanks so much! |
|
Thanks for merging this. I was little confused since I went through the linked PR and the change was made and reverted in the commit history. This clears it up. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1363 . Since it was a small change I thought to make a PR by myself. This is my first contribution so please let me know if I have missed anything or any other place that needs to be updated.
Thanks