[READY FOR REVIEW] Ch15 edits #898

carols10cents · 2017-08-25T22:00:20Z

Ok I think this is ready for review now @steveklabnik <3

shepmaster · 2017-09-11T14:18:07Z

second-edition/src/ch15-05-interior-mutability.md

+#### A Use Case for Interior Mutability: Mock Objects
+
+A *mock object* is the general programming concept for a type that stands in
+the place of another type during testing. Mock objects simulate real objects,


A test double is the generic thing that stands in for another. A mock object is a specific type of double that records what happens.

Suggest rewording to

A test double is the general programming concept for a type that stands in the place of another type during testing. Mock objects are specific types of test doubles that record what happens during a test so that we can assert that the correct actions took place.

steveklabnik

lookin great!

steveklabnik · 2017-09-11T15:00:38Z

second-edition/src/ch15-00-smart-pointers.md

-ordinary struct are that smart pointers implement the `Deref` and `Drop`
-traits, and in this chapter we’ll be discussing both of those traits and why
-they’re important to smart pointers.
+A *pointer* is the generic programming concept for an address to a location


I'm finding both the original sentence and this re-word a bit awkward; what about

A pointer is a general concept for a variable that contains an address in memory. This address refers to, or "points at", some other data.

steveklabnik · 2017-09-11T15:01:19Z

second-edition/src/ch15-00-smart-pointers.md

+*reference*, which we learned about in Chapter 4. References are indicated by
+the `&` symbol and borrow the value that they point to. They don't have any
+special abilities other than referring to data, but they also don't have any
+more overhead than they need to do straightforward referencing, so they're used


they also don't have any overhead, so they're used

steveklabnik · 2017-09-11T15:02:34Z

second-edition/src/ch15-00-smart-pointers.md

+
+* `Box<T>` for allocating values on the heap
+* `Rc<T>`, a reference counted type that enables multiple ownership
+* `Ref` and `RefMut`, accessed through `RefCell<T>`, a type that enforces the


Ref<T> and RefMut<T>

steveklabnik · 2017-09-11T15:03:49Z

second-edition/src/ch15-01-box.md

+advantage to this can be, help them know when they'd use this? -->
+<!-- Correct! Recap below: /Carol -->
+
+Boxes don't have a lot of performance overhead, but they don't have a lot of


I am slightly unsure about this phrasing; boxes have no overhead other than being on the heap. Not sure how to best communicate that....

There's the redirection, yeah? Isn't that a bit of overhead? I'm fine saying "Boxes don't have performance overhead other than being on the heap instead of on the stack", how does that sound?

That "redirection" is a consequence of being on the heap, nothing else 😄

how does that sound?

👍

steveklabnik · 2017-09-11T15:04:22Z

second-edition/src/ch15-01-box.md

+### Using a `Box` to Store Data on the Heap
+
+Before we get into a use case for `Box`, let's get familiar with the syntax and
+how to interact with values stored within a `Box`.


either box or Box<T> in this paragraph

steveklabnik · 2017-09-11T15:14:41Z

second-edition/src/ch15-04-rc.md

+turn it on. Others can come into the room and watch the TV. When the last
+person leaves the room, they turn the TV off because it's no longer being used.
+If someone turns the TV off while others are still watching it, there'd be
+uproar from the remaining TV watchers!


steveklabnik · 2017-09-11T15:16:49Z

second-edition/src/ch15-04-rc.md

+function and pass a reference to the `Rc` in `a` as an argument.
+
+We could have called `a.clone()` rather than `Rc::clone(&a)`, but Rust
+convention is to use `Rc::clone` in this case. The implementation of `clone`


yup:

Provide a more explicit way to "clone" a standard reference counted pointer. rfcs#1954

Add CLONE_ON_REF_PTR lint rust-clippy#2037

also you've heard about this before: rust-lang/rust#42137 (comment)

uuuuuuuuuuuuugh welp time to update my brain. thanks ❤️

steveklabnik · 2017-09-11T15:19:30Z

second-edition/src/ch15-05-interior-mutability.md

+certain memory safe scenarios are then allowed, whereas they are disallowed by
+the compile time checks. Static analysis, like the Rust compiler, is inherently
+conservative. Some properties of code are impossible to detect by analyzing the
+code: the most famous exampled is the Halting Problem, which is out of scope of


steveklabnik · 2017-09-11T15:21:09Z

second-edition/src/ch15-05-interior-mutability.md

+RefCell<T> is, perhaps a succinct round up would help? -->
+<!-- Done /Carol -->
+
+To recap the reasons to choose `Box<T>`, `Rc<T>`, or `RefCell<T>`:


putting this at this part of the book feels weird to me; it feels like it should be a summary, but we don't really have "end of the chapter summaries" or anything. hm

yeah i just put it in here to satisfy the comment. it feels a little weird in this spot too :-/ wdyt-- take it out entirely? we do have the ## Summary section at the end of 15-06?

yeah either take it out or put it in the summary. i'd lean towards taking it out

so natalie said she really liked this section here, that it tied things together before getting deep into interior mutability.

hmmmmmmmmmmm

steveklabnik · 2017-09-11T15:27:08Z

second-edition/src/ch15-05-interior-mutability.md

+`Mutex<T>`, which offers interior mutability that's safe to use across threads,
+and we'll be discussing its use in the next chapter on concurrency. Check out
+the standard library docs for more details on the differences between these
+types.


this whole example is excellent, thanks so much for all the work on it ❤️

carols10cents · 2017-09-18T20:50:03Z

@steveklabnik could you review these changes that i made to address comments from you, jake, natalie, and open issues for this chapter? 17da5ac...2fa362e

steveklabnik · 2017-09-19T14:25:59Z

Looks good to me, though one of those commit messages is now incorrect in the other direction, as I commented on the issue it's addressing.

Fixes #729.

Fixes #717.

Fixes #606.

Fixes #575.

Connects to #538.

carols10cents · 2017-09-19T17:57:17Z

ok, i fixed the commit message and i'm merging this and sending over to nostarch :) thank youuuuuuu

carols10cents force-pushed the ch15-edits branch 5 times, most recently from 79c08bf to 6b01ff8 Compare September 1, 2017 21:39

carols10cents force-pushed the ch15-edits branch from f5b37d1 to 5401713 Compare September 9, 2017 21:23

carols10cents requested a review from steveklabnik September 10, 2017 16:04

carols10cents changed the title ~~[NOT DONE YET] Ch15 edits~~ [READY FOR REVIEW] Ch15 edits Sep 11, 2017

shepmaster reviewed Sep 11, 2017

View reviewed changes

steveklabnik reviewed Sep 11, 2017

View reviewed changes

carols10cents mentioned this pull request Sep 18, 2017

Smart Pointer dereferencing rules #538

Closed

carols10cents added 17 commits September 19, 2017 13:27

Edits to 15-00

dfcfc6e

Edits to 15-01

27addf4

Edits to 15-02

8be1666

Edits to 15-03

c2014ea

Edits to 15-04

88ae5d9

Edits to 15-05

4940027

Edits to 15-06

12d1fce

Whoops missed a change to Rc::clone

e53f22a

Make some more edits to ch 15

92e2630

Clarify size of enum varants; fixes #886

3864b38

Take care of all the .clones called on smart pointers

d0abf1f

Fixes #729.

Document and show drop order

90af43b

Fixes #717.

Dance around the exact size of a box

aa13bc1

Fixes #606.

Tweak reference cycle section title to be less misleading

398ad3b

Fixes #575.

Fix what is dereferencing what how, ref auto dereferencing on methods

0666228

Connects to #538.

Spellingz

b061886

fancy quotes

68267b9

nostarchify

fc3a73d

carols10cents force-pushed the ch15-edits branch from 04a432f to fc3a73d Compare September 19, 2017 17:28

carols10cents merged commit 017f511 into master Sep 19, 2017

carols10cents deleted the ch15-edits branch September 19, 2017 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[READY FOR REVIEW] Ch15 edits #898

[READY FOR REVIEW] Ch15 edits #898

carols10cents commented Aug 25, 2017 •

edited

Loading

shepmaster Sep 11, 2017

steveklabnik left a comment

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

carols10cents Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

carols10cents Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

steveklabnik Sep 11, 2017

carols10cents Sep 11, 2017

steveklabnik Sep 11, 2017

carols10cents Sep 18, 2017

steveklabnik Sep 18, 2017

steveklabnik Sep 11, 2017

carols10cents commented Sep 18, 2017

steveklabnik commented Sep 19, 2017

carols10cents commented Sep 19, 2017

[READY FOR REVIEW] Ch15 edits #898

[READY FOR REVIEW] Ch15 edits #898

Conversation

carols10cents commented Aug 25, 2017 • edited Loading

Choose a reason for hiding this comment

steveklabnik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carols10cents commented Sep 18, 2017

steveklabnik commented Sep 19, 2017

carols10cents commented Sep 19, 2017

carols10cents commented Aug 25, 2017 •

edited

Loading