Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when alias shadows external subcommand #10082

Merged
merged 6 commits into from
Nov 17, 2021
Merged

Warn when alias shadows external subcommand #10082

merged 6 commits into from
Nov 17, 2021

Commits on Nov 14, 2021

  1. Warn when alias shadows external subcommand 

    As per rust-lang#10049, we start by emitting a warning when an alias shadows an
existing external subcommand. After a transition period (duration not
specified), we will make this a hard error.
    @basile-henry
    basile-henry committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    5bfd345 View commit details
    Browse the repository at this point in the history

  2. Update test for warning for alias shadowing an external subcommand

    @basile-henry
    basile-henry committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    9f768bb View commit details
    Browse the repository at this point in the history

  3. Update tests/testsuite/cargo_alias_config.rs

    @basile-henry
    basile-henry committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    2ead2d9 View commit details
    Browse the repository at this point in the history

  4. Update tests/testsuite/cargo_alias_config.rs

    @basile-henry
    basile-henry committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    3a5bb75 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Add details in warning for alias shadowing external subcommands

    @basile-henry
    basile-henry committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cba8503 View commit details
    Browse the repository at this point in the history

  2. Add test for alias shadowing external subcommand 

    This is currently still permitted, so we only test that the warning is properly issued
    @basile-henry
    basile-henry committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0b4e2ca View commit details
    Browse the repository at this point in the history