Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit warning upon encountering multiple packages with the same name #10701

Merged
merged 1 commit into from
May 31, 2022
Merged

Emit warning upon encountering multiple packages with the same name #10701

merged 1 commit into from
May 31, 2022

Conversation

danilhendrasr
Copy link
Contributor

Fixes: #10669

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2022
@danilhendrasr
Copy link
Contributor Author

Seems like the tests failed, I'll get back to it.

Muscraft
Muscraft reviewed May 27, 2022
View reviewed changes
tests/testsuite/path.rs Outdated Show resolved Hide resolved
weihanglo
weihanglo reviewed May 28, 2022
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you squash git commits?

tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/path.rs Outdated Show resolved Hide resolved
@danilhendrasr
Copy link
Contributor Author

By squashing git commits, do you mean by doing this?

@weihanglo
Copy link
Member

By squashing git commits, do you mean by doing this?

Sort of. It's a good habit to make commits meaningful for future backtraces :)
You can run git rebase to complete that in command line (ref)

@danilhendrasr
Copy link
Contributor Author

Done, have I done it right though? Cause I'm not familiar with this kind of situation haha.

weihanglo
weihanglo approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

I assume that this warning won't be too noisy in practice. If it turns out screaming too much or anyone in the cargo team disagrees, we can revert it at anytime.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 31, 2022

📌 Commit e903f7d has been approved by weihanglo

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2022
@bors
Copy link
Collaborator

bors commented May 31, 2022

⌛ Testing commit e903f7d with merge 38472bc...

@bors
Copy link
Collaborator

bors commented May 31, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 38472bc to master...

@bors bors merged commit 38472bc into rust-lang:master May 31, 2022
@ehuss ehuss mentioned this pull request Jun 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2022
@bors
Auto merge of rust-lang#97612 - ehuss:update-cargo, r=ehuss
12cd71f 
Update cargo

5 commits in 39ad1039d9e3e1746177bf5d134af4c164f95528..38472bc19f2f76e245eba54a6e97ee6821b3c1db
2022-05-25 00:50:02 +0000 to 2022-05-31 02:03:24 +0000
- Emit warning upon encountering multiple packages with the same name (rust-lang/cargo#10701)
- Guide new users to add use `super::*;` to `mod test` (rust-lang/cargo#10706)
- Document how to debug change detection events (rust-lang/cargo#10708)
- fix(publish): add more check when use `publish -p <SPEC>` (rust-lang/cargo#10677)
- fix key formatting when switching to a dotted `WorkspaceSource` (rust-lang/cargo#10705)
@weihanglo weihanglo mentioned this pull request Jun 13, 2022
Closed
@ehuss ehuss added this to the 1.63.0 milestone Jun 22, 2022
@epage epage mentioned this pull request Apr 10, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muscraft Muscraft Muscraft left review comments

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

No warning when Git dependency repository contains multiple packages with the same name
6 participants
@danilhendrasr @rust-highfive @weihanglo @bors @Muscraft @ehuss