Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused_imports warning #12876

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix unused_imports warning #12876

merged 1 commit into from
Oct 24, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 24, 2023

rust-lang/rust#116033 recently improved the fidelity of the unused_imports warning, causing this code to surface as something that is not being used (because the context module is not publicly exported, and nothing was referencing these imports). This fixes the warning by removing the unused imports.

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've seen these warnings as well.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2023

📌 Commit 3dcf93f has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2023
@bors
Copy link
Collaborator

bors commented Oct 24, 2023

⌛ Testing commit 3dcf93f with merge df35092...

@bors
Copy link
Collaborator

bors commented Oct 24, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing df35092 to master...

@bors bors merged commit df35092 into rust-lang:master Oct 24, 2023
20 checks passed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 25, 2023
Update cargo

2 commits in d2f6a048529eb8e9ebc55d793abd63456c98fac2..df3509237935f9418351b77803df7bc05c009b3d
2023-10-20 18:25:30 +0000 to 2023-10-24 23:09:01 +0000
- Fix unused_imports warning (rust-lang/cargo#12876)
- Warn about crate name's format when creating new crate (rust-lang/cargo#12766)

r? ghost
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2023
Rollup merge of rust-lang#117150 - weihanglo:update-cargo, r=weihanglo

Update cargo

2 commits in d2f6a048529eb8e9ebc55d793abd63456c98fac2..df3509237935f9418351b77803df7bc05c009b3d
2023-10-20 18:25:30 +0000 to 2023-10-24 23:09:01 +0000
- Fix unused_imports warning (rust-lang/cargo#12876)
- Warn about crate name's format when creating new crate (rust-lang/cargo#12766)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependency-resolution Area: dependency resolution and the resolver S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants