Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proc-macro example from dep no longer affects feature resolution #13892

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix: proc-macro example from dep no longer affects feature resolution #13892

merged 3 commits into from
Jun 10, 2024

Commits on Jun 9, 2024

  1. refactor: rename is_proc_macro to reflect it checks every targets

    @weihanglo
    weihanglo committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    a201d25 View commit details
    Browse the repository at this point in the history

  2. test: show proc macro example from dep affecting feature unificaiton

    @weihanglo
    weihanglo committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    2b0df94 View commit details
    Browse the repository at this point in the history

  3. fix: proc-macro example from dep no longer affects feature resolution 

    Previously when checking if a dependency is a proc-macro,
the v2 feature resolve resolver v2 looks for `proc-macro = true`
for every target of the dependency.
However, it's impossible to depend on a non-lib target as a proc-macro.

This fix switches to only check if `proc-macro = true` for `[lib]`
target for a dependency.
    @weihanglo
    weihanglo committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    0ead10e View commit details
    Browse the repository at this point in the history