Verify build-std resolve against original lockfile #13916

adamgemmell · 2024-05-15T11:22:04Z

What does this PR try to resolve?

Ensures that the resolve of the standard library when using build-std is a subset of the lockfile from the library source, as per discussion on rust-lang/wg-cargo-std-aware#38. It is a runtime version of the test added here: #13404

Fixes rust-lang/wg-cargo-std-aware#38

How should we test and review this PR?

It can be manually tested by running cargo build -Zbuild-std --target=[host] and seeing the command succeed. I'm not sure what behaviour can exercise the negative test case.

Additional information

Co-authored-by: Lawrence Tang lawrence.tang@arm.com

rustbot · 2024-05-15T11:22:09Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

adamgemmell · 2024-05-15T11:22:48Z

r? @ehuss

(nvm, I forgot a file 🙃)

Co-authored-by: Lawrence Tang <lawrence.tang@arm.com>

src/cargo/core/compiler/standard_lib.rs

epage · 2024-06-06T21:21:41Z

src/cargo/core/compiler/standard_lib.rs

+        let pkg_name = resolved_pkg.name().to_string();
+        let pkg_ver = resolved_pkg.version().to_string();


why do we need to to_string these?

src/cargo/core/compiler/standard_lib.rs

weihanglo · 2024-07-01T16:17:26Z

@rustbot author

bors · 2024-08-06T12:46:33Z

☔ The latest upstream changes (presumably #14358) made this pull request unmergeable. Please resolve the merge conflicts.

weihanglo · 2024-08-06T17:11:41Z

Close. See rust-lang/wg-cargo-std-aware#38 (comment).

rustbot assigned weihanglo May 15, 2024

rustbot added A-dependency-resolution Area: dependency resolution and the resolver A-lockfile Area: Cargo.lock issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2024

rustbot assigned ehuss and unassigned weihanglo May 15, 2024

Verify build-std resolve against original lockfile

eda17f3

Co-authored-by: Lawrence Tang <lawrence.tang@arm.com>

adamgemmell force-pushed the dev/adagem01/verify-std-lock branch from 4f5aa4d to eda17f3 Compare May 20, 2024 08:52

epage reviewed Jun 6, 2024

View reviewed changes