Hide SerializedDependency #2201
Conversation
SerializedDependency can be a private implementation detail now.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Ok, quick GitHub search says that |
This hides `SerializedDependency` from general public, as requested [here](#1434 (comment)). It also hides `SerializedManifest` which was (wrongly?) exposed. This is required for #2196. I want to move in small steps this time, hence the separate PR. Technically this break backwards compatibility, because `SerializedDependency` and `SerializedManifest` were public (`SerializedPackage` was private however). Are such changes allowed in cargo?
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This hides
SerializedDependencyfrom general public, as requested here. It also hidesSerializedManifestwhich was (wrongly?) exposed.This is required for #2196. I want to move in small steps this time, hence the separate PR.
Technically this break backwards compatibility, because
SerializedDependencyandSerializedManifestwere public (SerializedPackagewas private however). Are such changes allowed in cargo?