Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host dependency path via -L for cross compiles #3335

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

alexcrichton
Copy link
Member

Now that proc-macro crates can reexport from their dependencies we need to be
able to find the other crates, so ensure that we pass an appropriate -L flag.

Closes #3334

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Dec 1, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 1, 2016

📌 Commit 58a2916 has been approved by brson

@bors
Copy link
Collaborator

bors commented Dec 2, 2016

☔ The latest upstream changes (presumably #3310) made this pull request unmergeable. Please resolve the merge conflicts.

Now that proc-macro crates can reexport from their dependencies we need to be
able to find the other crates, so ensure that we pass an appropriate -L flag.

Closes rust-lang#3334
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Collaborator

bors commented Dec 2, 2016

📌 Commit a298346 has been approved by brson

@bors
Copy link
Collaborator

bors commented Dec 2, 2016

⌛ Testing commit a298346 with merge 307a613...

bors added a commit that referenced this pull request Dec 2, 2016
Add host dependency path via -L for cross compiles

Now that proc-macro crates can reexport from their dependencies we need to be
able to find the other crates, so ensure that we pass an appropriate -L flag.

Closes #3334
@bors
Copy link
Collaborator

bors commented Dec 2, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 307a613 to master...

@bors bors merged commit a298346 into rust-lang:master Dec 2, 2016
@alexcrichton alexcrichton deleted the fix-xcomiple branch December 2, 2016 17:42
@ehuss ehuss added this to the 1.15.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support proc-macro reexports
5 participants