Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --build-plan for 'cargo build' #4734

Closed
wants to merge 1 commit into from

Conversation

mshal
Copy link
Contributor

@mshal mshal commented Nov 20, 2017

With 'cargo build --build-plan', cargo does not actually run any
commands, but instead prints out what it would have done in the form of
a JSON data structure.

Fixes #3815

With 'cargo build --build-plan', cargo does not actually run any
commands, but instead prints out what it would have done in the form of
a JSON data structure.

Fixes rust-lang#3815
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.21.0. Please double check that you specified the right target!

@mshal
Copy link
Contributor Author

mshal commented Nov 20, 2017

I filed this against rust-1.21.0 since that is what mozilla-central builds with. I can try to rebase against master if that would help, but IIRC the master version of cargo wouldn't build m-c the last time I tried.

@cyplo
Copy link

cyplo commented Mar 24, 2018

Heya ! Any updates on this one ? Would this apply to master cleanly this time ?

@mshal
Copy link
Contributor Author

mshal commented Apr 5, 2018

I've rebased to the latest cargo master here: #5301

I also updated it slightly to make the output consistent when executed multiple times.

@mshal mshal closed this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants