Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid deleting trees in Cargo's tests #5131

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

An attempt at rust-lang/rust#48775

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2018

📌 Commit d856711 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 6, 2018

⌛ Testing commit d856711 with merge 03af18ce262ea477514f19b3562288a31ac784c8...

@bors
Copy link
Collaborator

bors commented Mar 6, 2018

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Mar 6, 2018

Oh the irony.

[00:17:50] failures:
[00:17:50] 
[00:17:50] ---- build_script::rename_with_link_search_path stdout ----
[00:17:50] 	running `C:\projects\cargo\target\debug\cargo.exe build`
[00:17:50] running `C:\projects\cargo\target\debug\cargo.exe run`
[00:17:50] thread 'build_script::rename_with_link_search_path' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 5, kind: PermissionDenied, message: "Access is denied." }', libcore\result.rs:945:5
[00:17:50] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:17:50] 
[00:17:50] 
[00:17:50] failures:
[00:17:50]     build_script::rename_with_link_search_path
[00:17:50] 
[00:17:50] test result: FAILED. 1164 passed; 1 failed; 9 ignored; 0 measured; 0 filtered out

@alexcrichton
Copy link
Member Author

Well I guess that answers that question!

Turns out this was the wrong unwrap anyway, closing.

@alexcrichton alexcrichton deleted the another branch July 18, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants