-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of namespaced features (see #1286) #5300
Merged
Merged
Commits on Apr 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e357d17 - Browse repository at this point
Copy the full SHA e357d17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4966f53 - Browse repository at this point
Copy the full SHA 4966f53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 797d453 - Browse repository at this point
Copy the full SHA 797d453View commit details -
Keep track of namespaced-features flag in Summary objects
For now, all Summaries from a registry have it set to false.
Configuration menu - View commit details
-
Copy full SHA for a9f163e - Browse repository at this point
Copy the full SHA a9f163eView commit details -
Take feature namespace into account while building summary (fixes rus…
…t-lang#1286) Here's an attempt at a table to cover the different cases: Feature Old (must be in features table) Continue Namespaced (might be stray value) In features table: Check that Crate dependency is in the list -> Non-optional dependency: Bail [PREVIOUSLY: bailed for non-optional dependency] -> Optional dependency: Insert feature of this name -> Else: Bail [PREVIOUSLY: bailed for unknown dependency or feature] Crate Old (might be stray value) Non-optional dependency: Bail No dependency found: Bail Namespaced Non-optional dependency: Bail No dependency found: Bail CrateFeature Old No dependency found: Bail Namespaced No dependency found: Bail
Configuration menu - View commit details
-
Copy full SHA for cb533ae - Browse repository at this point
Copy the full SHA cb533aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5d023 - Browse repository at this point
Copy the full SHA dc5d023View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a4282 - Browse repository at this point
Copy the full SHA f5a4282View commit details
Commits on Apr 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0b6f420 - Browse repository at this point
Copy the full SHA 0b6f420View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.