Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of namespaced features (see #1286) #5300

Merged
merged 8 commits into from
Apr 30, 2018

Commits on Apr 28, 2018

  1. Configuration menu
    Copy the full SHA
    e357d17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4966f53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    797d453 View commit details
    Browse the repository at this point in the history
  4. Keep track of namespaced-features flag in Summary objects

    For now, all Summaries from a registry have it set to false.
    djc committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    a9f163e View commit details
    Browse the repository at this point in the history
  5. Take feature namespace into account while building summary (fixes rus…

    …t-lang#1286)
    
    Here's an attempt at a table to cover the different cases:
    
    Feature
        Old (must be in features table)
            Continue
        Namespaced (might be stray value)
            In features table: Check that Crate dependency is in the list
            -> Non-optional dependency: Bail [PREVIOUSLY: bailed for non-optional dependency]
            -> Optional dependency: Insert feature of this name
            -> Else: Bail [PREVIOUSLY: bailed for unknown dependency or feature]
    
    Crate
        Old (might be stray value)
            Non-optional dependency: Bail
            No dependency found: Bail
        Namespaced
            Non-optional dependency: Bail
            No dependency found: Bail
    
    CrateFeature
        Old
            No dependency found: Bail
        Namespaced
            No dependency found: Bail
    djc committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    cb533ae View commit details
    Browse the repository at this point in the history
  6. Add tests for namespaced features

    djc committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    dc5d023 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f5a4282 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Configuration menu
    Copy the full SHA
    0b6f420 View commit details
    Browse the repository at this point in the history