Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit correct project name with --name #5446

Merged
merged 2 commits into from
May 2, 2018
Merged

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented May 1, 2018

Fixes #5440

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 2, 2018

📌 Commit 1edfd9b has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented May 2, 2018

⌛ Testing commit 1edfd9b with merge 2eebc86...

bors added a commit that referenced this pull request May 2, 2018
Emit correct project name with --name

Fixes #5440
@bors
Copy link
Collaborator

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2eebc86 to master...

@bors bors merged commit 1edfd9b into rust-lang:master May 2, 2018
@phrohdoh
Copy link

phrohdoh commented May 2, 2018

That was quick! Thanks @csmoe. 😄

@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo new with the --name flag results in reporting the package name incorrectly
7 participants