Use the base profile name when returning finishing #5492
Conversation
See the NOTE block: this is still "a bit inaccurate", but perhaps it's more accurate than just "release"/"dev". Refs rust-lang#4140
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -266,6 +265,7 @@ impl<'a> JobQueue<'a> { | |||
| // profiles used. However, to keep it simple and compatible with old | |||
| // behavior, we just display what the base profile is. | |||
| let profile = cx.bcx.profiles.base_profile(self.is_release); | |||
There was a problem hiding this comment.
Hm, I think the comment here is intended to refer primarily to optimized and debuginfo settings, because different crates might be compiled with different optimization/debuginfo settings, even if they are linked into a single artifact at the end. Nevertheless, the profile is the same across the whole compilation, the variation is internal to profile.
We also are thinking about removing profiles other than dev/release, so I would say that the current behavior is what we actually want, even if it is not 100% technically accurate.
There was a problem hiding this comment.
OK. No harm done.
Perhaps some of what you said should appended to #4140.
|
Thanks to your comment in Gitter (https://gitter.im/rust-lang/cargo?at=5af6d407862c5e33e92bf2ca) I was able to test that this had no effect on my manual test case: 22:27:53 $ cargo +nightly bench
Finished release [optimized] target(s) in 0.05 secs
Running target/release/deps/t_release_profile-5c15914beb0601d3
running 1 test
test tests::bench_add_two ... bench: 0 ns/iter (+/- 0)
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 0 filtered out
22:29:03 $ rustup run nightly /d/cargo/target/debug/cargo bench
Finished release [optimized] target(s) in 0.04s
Running target/release/deps/t_release_profile-81bdca9b0b4ae7a6
running 1 test
test tests::bench_add_two ... bench: 0 ns/iter (+/- 0)
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 0 filtered out |
See the NOTE block: this is still "a bit inaccurate", but perhaps it's
more accurate than just "release"/"dev".
Refs #4140