Allow rustc bootstrap to use unstable features even though it's using a beta-cargo #5613
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/cargo/core/features.rs
Outdated
| } | ||
| if let Ok(override_channel) = env::var("__CARGO_TEST_CHANNEL_OVERRIDE_DO_NOT_USE_THIS") { | ||
| return override_channel; | ||
| } |
There was a problem hiding this comment.
This probably should take precedence over RUSTC_BOOTSTRAP? It may not matter, but I don't know if RUSTC_BOOTSTRAP is set when running Cargo tests in rustc repo.
|
@bors r_ |
|
=/ @bors r+ |
|
📌 Commit 1bdb89d has been approved by |
Allow rustc bootstrap to use unstable features even though it's using a beta-cargo This is the sane alternative to rust-lang/rust#51322 (comment) cc @kennytm
|
☀️ Test successful - status-appveyor, status-travis |
When building the sysroot or rust compiler with a beta or stable rustc binary the flag RUSTC_BOOTSTRAP can be set to 1 to allow rustc to allow the same features as the development channel. This is required as the rust compiler and sysroot make use of unstable features. See here: rust-lang/cargo#5613
This is the sane alternative to rust-lang/rust#51322 (comment)
cc @kennytm