Only use non-absolute paths for path dependencies
#5935
Conversation
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
How is the test asserting the fix in behaviour? Also, from your wording, is there a difference between non-absolute and relative? |
|
Ah the test is asserting the correct behavior by ensuring that the second compile doesn't print that it's compiling The path passed to rustc largely only affects error messages and debuginfo, but due to debuginfo it affects the final artifact which means Cargo has to cache it separately. |
|
☔ The latest upstream changes (presumably #5628) made this pull request unmergeable. Please resolve the merge conflicts. |
Previously Cargo would use a non-absolute path for any dependency contained within the workspace root but this switches Cargo to only using relative paths for `path` dependencies. In practice this shouldn't make much difference, but for vendored crates and moving around `CARGO_HOME` it can produce more consistent results when target directories are shared. Closes rust-lang#5923
alexcrichton
force-pushed
the
vendor-paths
branch
from
80d1f3c
to
6e57be5
Compare
|
r? @ehuss |
|
@bors r+ I'm not very familiar with vendoring packages, but I can't think of any specific problems with this. I'll look at the error with |
|
📌 Commit 6e57be5 has been approved by |
Only use non-absolute paths for `path` dependencies Previously Cargo would use a non-absolute path for any dependency contained within the workspace root but this switches Cargo to only using relative paths for `path` dependencies. In practice this shouldn't make much difference, but for vendored crates and moving around `CARGO_HOME` it can produce more consistent results when target directories are shared. Closes #5923
|
☀️ Test successful - status-appveyor, status-travis |
Did you garner anything? I was thinking of opening an issue about it.. |
See #5940. To fix |
|
Oh damn I thought I'd searched #5940.. makes sense it's there.
|
…uild, r=alexcrichton Fix path::deep_dependencies_trigger_rebuild often failing in CI A shallow fix for `path::deep_dependencies_trigger_rebuild` in particular as it's failed my PRs often. See #5935 (comment), and #5940 for the bigger picture.
Previously Cargo would use a non-absolute path for any dependency contained
within the workspace root but this switches Cargo to only using relative paths
for
pathdependencies. In practice this shouldn't make much difference, butfor vendored crates and moving around
CARGO_HOMEit can produce moreconsistent results when target directories are shared.
Closes #5923