Force clippy to run. #7157
Merged
Force clippy to run. #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @yaahallo @Manishearth . WDYT? |
|
LGTM |
|
Yeah, this is definitely the behavior we want; perhaps with a flag or something to get the old behavior back. One of the reasons for switching to cargo for this was that such choices become easier. |
|
👍 |
|
@bors: r+ |
|
📌 Commit 1c6d8bb has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1c6d8bb with merge e4f49752d1c4ab78c9afc14bb25292a1eac7515c... |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
@bors: retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 23, 2019
Force clippy to run. This causes `cargo clippy-preview` to always run, instead of possibly emitting no output if it is run a second time. This is just a personal preference of mine, but I think would be better behavior which we have talked about before. I don't think the arguments that it should be "fast" like `cargo check` apply here. Once [cache-messages](#6986) is stabilized, this can be removed.
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Jul 23, 2019
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 26, 2019
Update cargo 11 commits in e3563dbdcd2e370bc4f11d080f739d82d25773fd..d0f828419d6ce6be21a90866964f58eb2c07cd56 2019-07-16 19:22:44 +0000 to 2019-07-23 21:58:59 +0000 - Remove include/exclude glob warning. (rust-lang/cargo#7170) - Optimize lock file format for git merge conflicts (rust-lang/cargo#7070) - Set up CI with Azure Pipelines (rust-lang/cargo#7139) - Force clippy to run. (rust-lang/cargo#7157) - Work around #61440 (rust-lang/cargo#7158) - initial working version of cargo fix --clippy (rust-lang/cargo#7069) - Optimize runtime of `#[cargo_test_macro]` (rust-lang/cargo#7146) - Don't fail if we can't acquire readonly lock (rust-lang/cargo#7149) - Add support for multiple --features options (rust-lang/cargo#7084) - Fix a typo in an env var name (rust-lang/cargo#7145) - Add a way to disable all nightly tests (rust-lang/cargo#7142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes
cargo clippy-previewto always run, instead of possibly emitting no output if it is run a second time.This is just a personal preference of mine, but I think would be better behavior which we have talked about before. I don't think the arguments that it should be "fast" like
cargo checkapply here. Once cache-messages is stabilized, this can be removed.