Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install: Remove orphaned executables. #7246

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 13, 2019

When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed.

I can place this new behavior behind the install-upgrade feature gate if anyone is uncomfortable with changing the behavior now.

cc #6797

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2019
@alexcrichton alexcrichton added the T-cargo Team: Cargo label Aug 13, 2019
@alexcrichton
Copy link
Member

Seems reasonable to me! I'd propose leaving this as-is, so...

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Aug 13, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken labels Aug 13, 2019
@rfcbot
Copy link
Collaborator

rfcbot commented Aug 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label Aug 14, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Aug 19, 2019

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 19, 2019

📌 Commit 5a59b80 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2019
@bors
Copy link
Collaborator

bors commented Aug 19, 2019

⌛ Testing commit 5a59b80 with merge f42275c...

bors added a commit that referenced this pull request Aug 19, 2019
`cargo install`: Remove orphaned executables.

When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed.

I can place this new behavior behind the `install-upgrade` feature gate if anyone is uncomfortable with changing the behavior now.

cc #6797
@bors
Copy link
Collaborator

bors commented Aug 19, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing f42275c to master...

@bors bors merged commit 5a59b80 into rust-lang:master Aug 19, 2019
@rfcbot rfcbot added finished-final-comment-period FCP complete and removed final-comment-period FCP — a period for last comments before action is taken labels Aug 24, 2019
@ehuss ehuss added this to the 1.39.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge FCP with intent to merge finished-final-comment-period FCP complete S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-cargo Team: Cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants