Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl auto traits for builtin types #604

Open
jackh726 opened this issue Sep 8, 2020 · 6 comments
Open

Impl auto traits for builtin types #604

jackh726 opened this issue Sep 8, 2020 · 6 comments
Assignees
@drtychai
Labels
C-chalk-solve Issues related to the chalk-solve crate good first issue A good issue to start working on Chalk with

Comments

@jackh726
Copy link
Member

jackh726 commented Sep 8, 2020 •
edited by rustbot
Loading

Right now, we only handle auto traits for Adts here. We need to extend auto trait support to all builtin types.
@jackh726 jackh726 added the good first issue A good issue to start working on Chalk with label Sep 8, 2020
@memoryleak47
Copy link
Contributor

I'm working on this!

@jackh726
Copy link
Member Author

@memoryleak47 still working on this?

You should be able to @rustbot claim

@memoryleak47
Copy link
Contributor

I was learning for an exam (which I had today) within the last week,
but yeah, I'll work on this in the near future.

@rustbot claim

@memoryleak47 memoryleak47 mentioned this issue Sep 18, 2020
Merged
bors added a commit that referenced this issue Sep 19, 2020
@bors
Auto merge of #612 - memoryleak47:fix-auto-traits, r=jackh726
9a3d72d 
Extend push_auto_trait_impl to built-in types

cc #604.
@jackh726
Copy link
Member Author

jackh726 commented Oct 6, 2020

Update, initial work was done here. But needs more: at least opaque and foreign types, maybe others.

@matthewjasper
Copy link
Contributor

#638 handles opaque types

@jackh726 jackh726 added the C-chalk-solve Issues related to the chalk-solve crate label Dec 11, 2020
@drtychai
Copy link
Contributor

Starting work on this today, hoping to finish out foreign types and any other ones that come up.

@rustbot claim

@rustbot rustbot assigned drtychai and unassigned memoryleak47 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drtychai drtychai

Labels
C-chalk-solve Issues related to the chalk-solve crate good first issue A good issue to start working on Chalk with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drtychai @memoryleak47 @matthewjasper @jackh726