Configure which platforms have f16 and f128 enabled by default
#652
Commits on Aug 3, 2024
-
-
Add back remaining config on
arm_aeabi_aliasIntrinsics marked with `arm_aeabi_alias = ...` were having the rest of their attributes eaten. Add them back.
-
Configure which platforms get
f16andf128enabled by defaultBy moving the logic for which platforms get symbols to `compiler_builtins` rather than rust-lang/rust, we can control where symbols get enabled without relying on Cargo features. Using Cargo features turned out to be a problem in [1]. This will help resolve errors like [2]. [1]: rust-lang/rust#128358 [2]: rust-lang/rust#128401
-
Make use of new
f16andf128config optionsChange from `not(feature = "no-f16-f128")` to `f16_enabled` or `f128_disabled`, as applicable.
-
Update which platforms have no
f16symbolsPreviously we were building the C versions of these symbols. Since we added the Rust version and updated compiler builtins, these are no longer available by default. This is unintentional, but it gives a better indicator of which symbol versions are not actually provided by the system. Use the list of build failures to correct the list of platforms that do not have `f16` symbols.
-
Correct
sys_avialableforf64->f16truncationThe `sys_available` gate was incorrect. Update it.
-
Update to the latest
rustc_apfloatThe latest version has a convenient `.unwrap()`. Increase the version so we can use this.
-
Since there are more platforms that do not have symbols present, we need to use `rustc_apfloat` for more conversion tests. Make use of the fallback like other tests, and refactor so each test gets its own function. Previously we were testing both apfloat and system conversion methods when possible. This changes to only test one or the other, depending on whether or not the system version is available. This seems reasonable because it is consistent with all other tests, but we should consider updating all tests to check both at some point. This also includes an adjustment of PowerPC configuration to account for the linking errors at [1]. [1]: rust-lang#655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.