Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weak linkage on windows and apple platforms #672

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. Fix weak linkage on windows and apple platforms

    There were some issues regarding windows and apple platform, we were
    exporting symbols that are already provided by the compiler but weren't
    marked as `weak` which resulted in conflicted symbols in the linking
    process.
    
    Initially, we didn't add `weak` because we thought it is not supported
    on windows and apple platforms, but it looks like its only not supported
    on windows-gnu platforms
    
    Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
    Amjad50 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6651d11 View commit details
    Browse the repository at this point in the history