Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeVisitor: do not hard-code a ControlFlow<()> result #383

Closed
3 tasks done
LeSeulArtichaut opened this issue Nov 5, 2020 · 2 comments
Closed
3 tasks done

TypeVisitor: do not hard-code a ControlFlow<()> result #383

LeSeulArtichaut opened this issue Nov 5, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Nov 5, 2020 •
edited
Loading

Proposal

Introduce a BreakTy associated type in TypeVisitor (which could default to ()) and change the visit_* methods to return ControlFlow<Visitor::BreakTy>.

Follow-up to #374 and rust-lang/rust#78182.

Mentors or Reviewers

@lcnr, @oli-obk

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@LeSeulArtichaut LeSeulArtichaut added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Nov 5, 2020
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 5, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 5, 2020

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Nov 5, 2020
This was referenced Nov 5, 2020
Merged
Merged
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 12, 2020
@LeSeulArtichaut LeSeulArtichaut added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Nov 15, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 15, 2020
bors added a commit to rust-lang/chalk that referenced this issue Nov 15, 2020
@bors
Auto merge of #651 - LeSeulArtichaut:visitor-breakty, r=jackh726
bc99ed6 
Introduce `Visitor::BreakTy`

Implements the equivalent of MCP rust-lang/compiler-team#383 in chalk.
r? `@jackh726`

~~Should probably be blocked on rust-lang/compiler-team#383.~~
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 17, 2020
@Dylan-DPC
Rollup merge of rust-lang#78779 - LeSeulArtichaut:ty-visitor-return, …
975b50d 
…r=oli-obk

Introduce `TypeVisitor::BreakTy`

Implements MCP rust-lang/compiler-team#383.
r? `@ghost`
cc `@lcnr` `@oli-obk`

~~Blocked on FCP in rust-lang/compiler-team#383.~~
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 17, 2020
@bors
Auto merge of rust-lang#78779 - LeSeulArtichaut:ty-visitor-return, r=…
e0ef0fc 
…oli-obk

Introduce `TypeVisitor::BreakTy`

Implements MCP rust-lang/compiler-team#383.
r? `@ghost`
cc `@lcnr` `@oli-obk`

~~Blocked on FCP in rust-lang/compiler-team#383.~~
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Nov 17, 2020
@bors
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
a467c51 
Introduce `TypeVisitor::BreakTy`

Implements MCP rust-lang/compiler-team#383.
r? `@ghost`
cc `@lcnr` `@oli-obk`

~~Blocked on FCP in rust-lang/compiler-team#383.~~
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 19, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this issue May 17, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @oli-obk @LeSeulArtichaut @rustbot