Assign a random team member on r? @rust-lang/<team>

[LeSeulArtichaut]

Attemps to close #187.

[camelid]

@LeSeulArtichaut this would be great to have! Are you planning on getting back to this?

[LeSeulArtichaut]

This depends on whether @Mark-Simulacrum wants to proceed with rust-lang/triagebot#433 first, but as that PR encountered some difficulties, maybe this can be revisited?

[Mark-Simulacrum]

Yeah, this seems like the right approach in the interim while we wait for GitHub to resolve the problems preventing full rollout of r? for assignment in triagebot. From a quick scroll through it looks like this wants to add team groups for the existing teams (probably at least libs and compiler perhaps?) to the real files too? I guess we can do that in follow-up PRs.

[LeSeulArtichaut]

This code looks really bad, I wonder who wrote it... Oh, hey me from (exactly) 9 months ago!

From a quick scroll through it looks like this wants to add team groups for the existing teams (probably at least libs and compiler perhaps?) to the real files too? I guess we can do that in follow-up PRs.

If I understand the code correctly, it first checks if a group matches the team name, so in r? @rust-lang/libs it's going to check if libs exists :

groups.get(match.group(2))

before checking if rust-lang/libs exists :

potential = groups.get("%s/%s" % (match.group(1), match.group(2)))

So I think we don't need to change the data files, because these teams already exist in

highfive/highfive/configs/rust-lang/rust.json

Lines 2 to 12 in f7434f5

	"groups": {
	"all": [],
	"compiler-team": ["@eddyb", "@estebank", "@matthewjasper",
	"@oli-obk", "@petrochenkov", "@varkor"],
	"compiler-team-contributors": ["@davidtwco", "@ecstatic-morse", "@lcnr"],
	"libs": ["@sfackler", "@dtolnay", "@JoshTriplett",
	"@withoutboats", "@cramertj", "@shepmaster", "@Mark-Simulacrum",
	"@kennytm", "@m-ou-se"],
	"infra-ci": ["@Mark-Simulacrum", "@kennytm", "@pietroalbini"],
	"rustdoc": ["@jyn514", "@GuillaumeGomez", "@ollie27"]
	},

[wesleywiser]

I would love to see this feature added. Is there anything I can do to help get this merged? I see this needs a rebase and maybe another review?

[LeSeulArtichaut]

Rebased.

[wesleywiser]

The changes seem reasonable to me but I don't know anything about Python

[wesleywiser]

@Mark-Simulacrum I think this is good to go if you want to take a look. 🙂