Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pthread_rwlockattr APIs #633

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Add pthread_rwlockattr APIs #633

merged 1 commit into from
Jun 29, 2017

Conversation

main--
Copy link
Contributor

@main-- main-- commented Jun 28, 2017

I'm basically trying to mirror the existing code for pthread_mutexattr.

Hopefully the non-linux parts are correct - finding the right definitions is rather confusing and occasionally even contradicts existing definitions (e.g. this pthread_condattr_t doesn't match #335).

@main-- main-- force-pushed the rwlockattr branch 3 times, most recently from 43d8ba7 to 7aee4e2 Compare June 28, 2017 14:43
@alexcrichton
Copy link
Member

@bors: r+

Awesome, thanks!

@bors
Copy link
Contributor

bors commented Jun 29, 2017

📌 Commit b2de1fd has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jun 29, 2017

⌛ Testing commit b2de1fd with merge 83f5543...

bors added a commit that referenced this pull request Jun 29, 2017
Add pthread_rwlockattr APIs

I'm basically trying to mirror the existing code for pthread_mutexattr.

Hopefully the non-linux parts are correct - finding the right definitions is rather confusing and occasionally even contradicts existing definitions (e.g. [this](https://github.com/practicalswift/osx/blob/a26375e7b3e01c83e26a23977f909438ed9b31b4/src/libpthread/src/internal.h#L295) `pthread_condattr_t` doesn't match #335).
@bors
Copy link
Contributor

bors commented Jun 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 83f5543 to master...

@bors bors merged commit b2de1fd into rust-lang:master Jun 29, 2017
@main-- main-- deleted the rwlockattr branch June 29, 2017 13:53
bors added a commit that referenced this pull request Jul 3, 2017
Fix types of PTHREAD_PROCESS_* constants

Somehow these ended up with wrong types in #633.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants