Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mark from URL on escape. #1427

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 4, 2021

When clicking on a search result, the page will highlight the search terms. Pressing escape will remove the highlight. However, the ?highlight=... would remain in the URL. This can be annoying if you want to copy and paste the URL to use elsewhere. This changes it so that hitting escape will also remove the ?highlight=... from the URL when hitting escape.

@Dylan-DPC-zz Dylan-DPC-zz merged commit 09e7bb7 into rust-lang:master Jan 5, 2021
notriddle pushed a commit to notriddle/mdBook that referenced this pull request Dec 23, 2021
rubenmoor pushed a commit to rubenmoor/mdBook that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants