Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cargo build --features=regenerate-css on win 10 / nightly #343

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented Jun 20, 2017

fixes https://github.com/azerupi/mdBook/issues/342

@azerupi I finally had little time to tinker with win 10 box and fixed the long standing bug with cargo build --features=regenerate-css.
also added css regeneration build to appveyor.

@budziq
Copy link
Contributor Author

budziq commented Jun 20, 2017

appveyor nightly build fails illustrating the https://github.com/azerupi/mdBook/issues/342 issue.

@budziq budziq force-pushed the appveyor_css branch 4 times, most recently from d0e29ea to d0ae366 Compare June 27, 2017 05:21
@azerupi azerupi added the S-Blocked-Upstream Status: Blocked Upstream label Jun 27, 2017
@budziq budziq force-pushed the appveyor_css branch 2 times, most recently from e918030 to a405185 Compare August 12, 2017 11:19
also added cargo build --features=regenerate-css to appveyor.yml
@budziq budziq changed the title added cargo build --features=regenerate-css to appveyor.yml fixed cargo build --features=regenerate-css on win 10 / nightly Aug 12, 2017
@budziq budziq removed the S-Blocked-Upstream Status: Blocked Upstream label Aug 14, 2017
@budziq
Copy link
Contributor Author

budziq commented Sep 5, 2017

@azerupi do you think it's ok to merge this one?

@azerupi
Copy link
Contributor

azerupi commented Sep 5, 2017

Yes, I glanced over it and it looks fine (way better than before 😉 )

@azerupi azerupi merged commit a6a7c95 into rust-lang:master Sep 5, 2017
@budziq
Copy link
Contributor Author

budziq commented Sep 5, 2017

Thanks!

Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
fixed `cargo build --features=regenerate-css` on win 10 / nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--features=regenerate-css does not work on nightly (Windows 10)
2 participants