add another weak mem consistency test #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, but unfortunately, the test still passes even if I replace the FAA by loads... bummer.^^ But still, seems like a good test to have. |
I think this is because of #2164. Try atomically reading x, y and z before spawning the threads (or hoist the allocation outside the loop and atomically write zero as initialisation) |
|
Ah, yes, with some initial stores added the bad execution happens quickly when I replace the FAA by a load. :) |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jul 14, 2022
add another weak mem consistency test `@cbeuw` your code seems to do this correctly? :D
|
@bors retry r+ |
bors
added a commit
that referenced
this pull request
Jul 14, 2022
add another weak mem consistency test `@cbeuw` your code seems to do this correctly? :D
|
@bors retry r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cbeuw your code seems to do this correctly? :D