Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with rustup before deploying to production #15

Closed
alexcrichton opened this issue May 10, 2017 · 1 comment · Fixed by #25
Closed

Test with rustup before deploying to production #15

alexcrichton opened this issue May 10, 2017 · 1 comment · Fixed by #25
Labels
A-reliability Issue that affects the reliability and operations of promote-release C-new-feature A new feature that we could implement

Comments

@alexcrichton
Copy link
Member

The automatic deployment process for nightly/beta should look like:

  • Deploy artifacts to dev
  • Download latest rustup
  • Ensure rustup works against artifacts in dev
  • Deploy artifacts to prod
@pietroalbini pietroalbini transferred this issue from rust-lang/rust-central-station Oct 26, 2020
This was referenced Oct 26, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 28, 2020
@bors
Auto merge of rust-lang#78409 - pietroalbini:build-manifest-checksum-…
717eb6c 
…cache, r=Mark-Simulacrum

Add checksums cache to build-manifest

During the release process we're currently calculating the SHA256 of each file three times:

1. In `build-manifest`, to fill the `hash = "f00"` keys of the manifests.
2. In `promote-release`, to generate the `.sha256` files.
3. In `promote-release`, to generate the `.asc` GPG signatures.

Calculations 1. and 2. could be merged into a single one if there was a way for `build-manifest` to pass the checksums it generated over to `promote-release`. Unfortunately calculation 3. can't be merged as GPG requires extra metadata to be hashed.

This PR adds support for merging 1. and 2. by creating the `BUILD_MANIFEST_CHECKSUM_CACHE` environment variable, which points to a JSON file storing a cache of all the calculated checksums. `build-manifest` will load it at startup and avoid generating existing checksums, and it will dump its internal checksums cache into it when it exits successfully.

This PR also allows to run `build-manifest` multiple times without the need to wait for checksums to be calculated in the following invocations. The speedup will allow to work torwards a fix for rust-lang/promote-release#15 without impacting the release process duration nor our storage costs.

This PR can be reviewed commit-by-commit.
r? `@Mark-Simulacrum`
@pietroalbini pietroalbini added A-reliability Issue that affects the reliability and operations of promote-release C-new-feature A new feature that we could implement labels Oct 28, 2020
@pietroalbini pietroalbini mentioned this issue Oct 29, 2020
Merged
@pietroalbini
Copy link
Member

Implementation PR for this is available at #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-reliability Issue that affects the reliability and operations of promote-release C-new-feature A new feature that we could implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure the release works before uploading the tarballs rust-lang/promote-release
2 participants
@alexcrichton @pietroalbini