Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lvalue and rvalue to place and value expressions #167

Merged
merged 2 commits into from
Dec 8, 2017

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Dec 2, 2017

This effort is already underway in the compiler as well, and this is the only other place we talk about these two kinds of expressions.

I also moved a lot of links down to the bottom of the page. I already painstakingly checked that every link was correct.

@matthewjasper
Copy link
Contributor

The files in src/expressions and the glossary (definition of initialized) also use 'lvalue' a lot.

@Havvy
Copy link
Contributor Author

Havvy commented Dec 3, 2017

Alright, I've updated those pages as well. I even did a grep to see if there were more uses, and didn't find any. And once again, I've painstakingly checked every link I modified to make sure they are correct.

@Havvy
Copy link
Contributor Author

Havvy commented Dec 3, 2017

Oh, right, almost forgot. Some usages of lvalue were to describe the actual memory location or place the expression refers to. I used both terms, rather haphazardly, in this case and I'm not sure which I should be using. Though really, a placement expression evaluates to a place sort of doesn't define place either.

We could continue to be wishy-washy about this and do something about it in another PR. Probably in the memory model section.

@steveklabnik
Copy link
Member

This looks good to me! Gonna need a rebase though; you're doing too much amazing work too quickly!

@Havvy
Copy link
Contributor Author

Havvy commented Dec 8, 2017

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants