Amend RFC2603 to allow mangled identifiers to start with a digit. #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
added
T-compiler
|
Looks good to me! |
eddyb
force-pushed
the
mangling-underscore-escaping
branch
from
e8ac8fb
to
e925a40
Compare
|
We often do an FCP for amendments, but I also think it's ok to "just do it" if it is small and not controversial amongst the folks who were active in the RFC itself. I am fine with this change (but I've not been following the RFC closely). |
|
I've now incorporated the changes into rust-lang/rust#57967, including testing them against rust-lang/rustc-demangle#26 (which has been merged and published). |
SimonSapin
changed the title
|
I took the liberty of adding “mangled” to the title. Without context, the title alone sounded like a change to Rust source syntax. |
eddyb
force-pushed
the
mangling-underscore-escaping
branch
from
e925a40
to
5a4d154
Compare
nikomatsakis
approved these changes
Oct 23, 2020
|
Merging as this reflects the actual implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested by @pnkfelix in #2603 (comment), and @michaelwoerister seemed to agree to it, but it didn't make it into the RFC before merging.
I also removed the
0-9->A-Jrewriting of Punycode's base-36 encoding, as it only existed to avoid having identifiers start with decimal digits, which would now work.cc @rust-lang/compiler Do we have a procedure for amending RFCs?