RFC: numerics reform

[aturon]

This RFC is preparation for API stabilization for the std::num module. The goal is to finish the simplification efforts started in @bjz's reversal of the numerics hierarcy.

Broadly, the proposal is to collapse the remaining numeric hierarchy in std::num, and to provide only limited support for generic programming (roughly, only over primitive numeric types that vary based on size). Traits giving detailed numeric hierarchy can and should be provided separately through the Cargo ecosystem.

Thus, this RFC proposes to flatten or remove most of the traits currently provided by std::num, and generally to simplify the module as much as possible in preparation for API stabilization.

Rendered

[Gankra]

Earlier drafts of this work were based on the listed alternative: more aggressive inlining of traits. iirc it was down to Float and Int, with SignedInt and UnsignedInt as potentials. FloatMath surviving is clearly motivated by the RFC, but what about the rest? Was it about deduplication and avoiding the more dubious methods like "abs on uints", or is this just a path of least resistance solution?

I wasn't under the impression that we were particularly interested in supporting using a generic "Num".

[aturon]

@gankro Thanks for bringing that up. I've revised the RFC with a new paragraph (see "Overview: the new hierarchy") to explain the motivation.

I think flattening Num away would be fine, and maybe the best move to make in terms of hitting the desired perception. Getting rid of Signed and UnsignedInt would be a deeper change.

[aturon]

@gankro on further reflection, I've decided that the original plan (without Num) is likely the better one. I've revised the RFC accordingly, but left the definition of Num in Alternatives for comparison.

[Gankra]

👍 this strikes me as a moderate compromise between the two extremes.

(I still think the signed/unsigned separation is a bit silly, but the majority seems to disagree)

[jsanders]

@aturon: Do you have any links where I can read about the ideas for replacing FromPrimitive and friends?

[aturon]

@jsanders See this proposal and the discussion on this issue about Ordinal.

[aturon]

Added these links to the RFC.

[Gankra]

Was having just Float, SignedInt, and UnsignedInt (and FloatMath as per discussion) ever evaluated? This is a denormalization that has more duplication, but avoids all the "this operation makes no sense" trouble. It also neatly matches what the primitive families actually are.

[aturon]

@gankro Yes, I thought about that possibility. The updated RFC gives a (somewhat weak) justification for Signed: we want those methods in the prelude, because unlike most of the other methods, they are truly basic operations that one expects to be present whenever working with a signed numeric type.

Also, while it's a bit far-fetched to imagine useful code that's generic over both ints and floats, being generic over signedness of ints is not so hard to imagine. (Note that the RFC does make some amount of generic programming over natural groupings of the primitive types an explicit goal.)

[Gankra]

Ah, I didn't process that only some of these would be part of the prelude. Okay, that makes sense.

[klutzy]

Are the numeric traits expected to be implemented outside of std or not? For example, is it reasonable if I implement custom i31 or f80 type?
In any case, it would be good to specify actual semantic of traits, e.g. UnsignedInt is only for mod 2^N arithmetic, to reduce confusion.

Currently Signed have some methods which have different edge cases for integers and floats. For example, Signed::abs() specifies both overflow behavior of primitive integers (int::MIN.abs()) and NaN behavior of floating numbers. Is it ok to preserve the trait with the specification?

My main concern is that signed integers have asymmetric range so generic functions over Signed may introduce overflow bugs. For example, we have overflow error for num::rational.

[aturon]

@klutzy

Are the numeric traits expected to be implemented outside of std or not? For example, is it reasonable if I implement custom i31 or f80 type?

It's not an explicit design goal, but for custom-sized "primitive" types it would probably make sense.

Currently Signed have some methods which have different edge cases for integers and floats. For example, Signed::abs() specifies both overflow behavior of primitive integers (int::MIN.abs()) and NaN behavior of floating numbers. Is it ok to preserve the trait with the specification?

The goal with Signed was not to support generic int/float programming, but rather to pull those methods out into something we could have in the prelude (so that they are always available). But we could instead merge the trait into Float and a SignedInt trait, and come up with a different solution for the prelude (or simply not include this functionality there).

I would welcome further input on the topic of what needs to go into the prelude. I worry that needing to import SignedInt in order to get the abs method will be very surprising. And on the other hand we don't want to include the full traits in the prelude, because we want to leave these names open for external numerics libraries.

[Gankra]

Maybe we should be evaluating a way to mark a trait as #[not-generic]? As in, "this is just an extension trait, being generic over it is not what you should be doing" and "this isn't intended to be implemented by custom types". Maybe a warn with an #[allow]?

[aturon]

@gankro It's an interesting thought. It could also be done via naming conventions. (Cf the -Prelude suffix proposed here)

[brendanzab]

Could we rename FPCategory to FloatCategory?

[brendanzab]

Thanks a bunch for drawing up best proposal for Rust numerics yet!

[brendanzab]

cc. @sebcrozet @SiegeLord

[brendanzab]

So in the docs should we be specific about what types should implement these traits? For example, I am guessing they would not be implemented by big integers and floats...?

[kennytm]

I have some code that relies only on field operations (Add + Sub + Mul + Div + Zero + One + Clone), and also a type to represent finite-field arithmetic (GF(2^64)) that Rem and the bitwise operations do not make sense.

What should be done if this RFC is to be merged? Since it seems Zero and One are going away?

[Gankra]

@kennytm Nothing prevents you from writing these traits in your own library, which I believe is the overall intent of this RFC: Make algebraic hierarchies a problem for the community to work out in the cargo ecosystem.

[brendanzab]

I am thinking it might be wise to start a numeric lib with things like the additive and multiplicative identities and such. Then folks have a place to turn once we kill some of these numeric traits. I began num-rs quite some time ago... maybe there is something we can salvage from there?

[alexcrichton]

Some of these have worried me in the past in the sense that although they are LLVM intrinsics, they're often lowered to function calls at compile-time into libraries like libm. By providing these functions in libcore we're semi-stating that they're available for everyone forever (some of them do have x86 instructions, for example), but we're not necessarily delivering on that statement.

A small wory, just wanted to point out why these are singled out for being in libcore rather than libstd. Anyone using these functions and libcore directly will likely already know how to get them anyway

[ruuda]

I am sorry for the late response. I’m only dealing with this now because the changes broke a project of mine. I understand the rationale behind the separation of Float and FloatMath, but from a usability point of view, the distinction is quite arbitrary. I have to use std::num::Float to be able to use sqrt(), but use std::num::FloatMath for cos()? Right now, I see no way of knowing whether a function is in Float or FloatMath except looking it up in the documentation. Could this be made more intuitive without changing the dependencies?

[aturon]

@ruud-v-a Thanks for the feedback! We're actually considering making std export a single Float trait that includes all of the methods. Stay tuned for additional changes in this space soon.

[andydude]

The only code associated with this comment are the traits below:

pub trait RotateLeft<RHS> {
    type Output;

    fn rotate_left(self, rhs: RHS) -> Self::Output;
}

pub trait RotateRight<RHS> {
    type Output;

    fn rotate_right(self, rhs: RHS) -> Self::Output;
}

pub trait SwapBytes<RHS> {
    fn swap_bytes(self) -> Self;

    fn from_be(x: Self) -> Self;
    fn from_le(x: Self) -> Self;
    fn to_be(self) -> Self;
    fn to_le(self) -> Self;
}

I would like to bring attention to the particular use case of using these subsets of the current Int trait implemented for std::simd types (like i16x8, i32x4, i64x2, u16x8, u32x4, u64x2). The reason why you can't implement Int for SIMD types is that even though NumCast is easy to implement as the broadcast operation (a SIMD type composed of 8 copies of the same value), the reverse operations in ToPrimitive cannot be implemented in a satisfactory way (You could take the first element, or the last element, but neither of these are attractive options). So there is no natural implementation of ToPrimitive for SIMD types.

A second reason why these method subsets are useful to separate from the Int trait is that the current rotate_left and rotate_right methods strictly enforce RHS=usize, which is typically how they are used, but there are algorithms that require these methods where RHS=Self (meaning each SIMD component is rotated a different amount). This is already expressible in the current Shl and Shr traits, which are intimately connected to the rotation methods. Imaging Self below replaced with u32x4 in the following example specializations:

impl Shl<usize, Output=Self> for ... { ... }
impl Shl<Self, Output=Self> for ... { ... }
impl Shr<usize, Output=Self> for ... { ... }
impl Shr<Self, Output=Self> for ... { ... }
impl RotateLeft<usize, Output=Self> for ... { ... }
impl RotateLeft<Self, Output=Self> for ... { ... }
impl RotateRight<usize, Output=Self> for ... { ... }
impl RotateRight<Self, Output=Self> for ... { ... }

After some experimentation, it seems that Shl<Self, Self> and Shr<Self, Self> are already implemented for all SIMD types. It would be a great benefit for SIMD users if the other, more common shift and rotation methods were also built-in.

A side note (and perhaps outside the scope of this comment) is that RotateLeft and RotateRight could be renamed Rol and Ror as they can be implemented in single instructions on some architectures, even though they're not traditional C operations. Evidence can be found on the LLVM mailing list that others who have also considered them core operations.

In conclusion, there are at least 2 compelling reasons (the ToPrimitive reason and the RotateLeft reason) to separate out rotation operations from the Int trait so that SIMD types may benefit from sharing the same methods as primitive types.