This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Make rustfmt an optional dependency #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
master
branch
2 times, most recently
from
5ebf9b7
to
fdceb35
Compare
|
How would rustfmt get disabled in the Rust repo? |
|
I'd check the compilation state of rustfmt before building rls and choose different features depending on that. |
|
sorry, to be clear, my question was how you would choose different features - do you know if that is possible from the Rust build system today? |
|
Oh it's not possible yet. But without adding this first, it's annoying to prototype. |
|
Ah, ok that makes sense. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for #149 (comment)