Fix missing unsafe block for the nightly change #10032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test baseline update (run |
oxalica
force-pushed
the
fix/format_args_missing_unsafe
branch
from
90d1885
to
15eccf2
Compare
lnicola
reviewed
Aug 26, 2021
| std::fmt::Arguments::new_v1(&[], &[##arg_tts]) | ||
| // It's unsafe since https://github.com/rust-lang/rust/pull/83302 | ||
| // Wrap an unsafe block to avoid false-positive `missing-unsafe` lint. | ||
| // FIXME: Currently we don't have `unused_unsafe` lint so an extra unsafe block won't cause issues on early |
There was a problem hiding this comment.
It's fine, we don't go out of our way to support older Rust versions.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10022
Tested via vscode extension.