Update rustc_pattern_analysis #16738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Mar 3, 2024
| @@ -88,7 +88,7 @@ ra-ap-rustc_lexer = { version = "0.35.0", default-features = false } | |||
| ra-ap-rustc_parse_format = { version = "0.35.0", default-features = false } | |||
| ra-ap-rustc_index = { version = "0.35.0", default-features = false } | |||
| ra-ap-rustc_abi = { version = "0.35.0", default-features = false } | |||
| ra-ap-rustc_pattern_analysis = { version = "0.37.0", default-features = false } | |||
| ra-ap-rustc_pattern_analysis = { version = "0.40.0", default-features = false } | |||
There was a problem hiding this comment.
Suggested change
| ra-ap-rustc_pattern_analysis = { version = "0.40.0", default-features = false } | |
| ra-ap-rustc_pattern_analysis = { version = "0.41.0", default-features = false } |
I don't think 0.40 actually includes your fix, and 0.41 will hopefully come out in a couple of hours.
We should probably bump that workflow to run earlier 😀.
There was a problem hiding this comment.
I checked, it does include the fix :) It was published shortly after the fix landed, to my own surprise
There was a problem hiding this comment.
Ah, sorry then. Still, can you bump it to the new version? It's out now.
There was a problem hiding this comment.
Just saw that ^^ Yeah I'll bump next time it's useful
|
Eh, whatever. We can upgrade next time. @bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #16656 but I can't check because we don't have a reproducer.