Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint_groups_priority is raised for rust_2018_idioms = "deny", warnings = "deny" #12270

Closed
Arnavion opened this issue Feb 11, 2024 · 0 comments · Fixed by #12827
Closed

lint_groups_priority is raised for rust_2018_idioms = "deny", warnings = "deny" #12270

Arnavion opened this issue Feb 11, 2024 · 0 comments · Fixed by #12827
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have

Comments

@Arnavion
Copy link
Contributor

Summary

If I understand correctly, this is a false positive for two different reasons:

  1. If a lint and a lint group have the same priority but also have the same level, then the order doesn't matter, so the lint need not fire.

  2. If the lint involved is warnings, then the order doesn't matter, so the lint need not fire.

Lint Name

lint_groups_priority

Reproducer

I tried this code:

[lints.rust]
rust_2018_idioms = "deny"
warnings = "deny"

I saw this happen:

error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:77:1
   |
77 | rust_2018_idioms = "deny"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
78 | warnings = "deny"
   | -------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
77 | rust_2018_idioms = { level = "deny", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I expected to see this happen:

Lint not triggered.

Version

rustc 1.78.0-nightly (d44e3b95c 2024-02-09)
binary: rustc
commit-hash: d44e3b95cb9d410d89cb8ab3233906a33f43756a
commit-date: 2024-02-09
host: x86_64-unknown-linux-gnu
release: 1.78.0-nightly
LLVM version: 17.0.6

Additional Labels

No response

@Arnavion Arnavion added C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have labels Feb 11, 2024
kpreid added a commit to kpreid/all-is-cubes that referenced this issue Feb 12, 2024
Nightly Clippy doesn't like having lints and groups at the same priority.
I'm not sure if this is a false positive or not (see
<rust-lang/rust-clippy#12270> for a related
discussion) but it seems reasonable to make the change regardless.
taiki-e added a commit to taiki-e/portable-atomic that referenced this issue Feb 22, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
    --> Cargo.toml:35:1
     |
  35 | rust_2018_idioms = "warn"
     | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
  36 | single_use_lifetimes = "warn"
     | -------------------- has the same priority as this lint
     |
     = note: the order of the lints in the table is ignored by Cargo
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
     = note: `#[deny(clippy::lint_groups_priority)]` on by default
  help: to have lints override the group set `rust_2018_idioms` to a lower priority
     |
  35 | rust_2018_idioms = { level = "warn", priority = -1 }
     |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/portable-atomic that referenced this issue Feb 22, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
    --> Cargo.toml:35:1
     |
  35 | rust_2018_idioms = "warn"
     | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
  36 | single_use_lifetimes = "warn"
     | -------------------- has the same priority as this lint
     |
     = note: the order of the lints in the table is ignored by Cargo
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
     = note: `#[deny(clippy::lint_groups_priority)]` on by default
  help: to have lints override the group set `rust_2018_idioms` to a lower priority
     |
  35 | rust_2018_idioms = { level = "warn", priority = -1 }
     |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/install-action that referenced this issue May 23, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:11:1
   |
11 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
12 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
11 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:16:1
   |
16 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
17 | pedantic = "warn"
18 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
16 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:17:1
   |
17 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
18 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
17 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/assert-unmoved that referenced this issue May 24, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:70:1
   |
70 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
71 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
70 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:75:1
   |
75 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
76 | pedantic = "warn"
77 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
75 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:76:1
   |
76 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
77 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
76 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/atomic-memcpy that referenced this issue May 24, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:54:1
   |
54 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
55 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
54 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:59:1
   |
59 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
60 | pedantic = "warn"
61 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
59 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:60:1
   |
60 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
61 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
60 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/build-context that referenced this issue May 24, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:38:1
   |
38 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
39 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
38 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:43:1
   |
43 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
44 | pedantic = "warn"
45 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
43 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:44:1
   |
44 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
45 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
44 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/assert-unmoved that referenced this issue May 24, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:70:1
   |
70 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
71 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
70 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:75:1
   |
75 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
76 | pedantic = "warn"
77 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
75 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:76:1
   |
76 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
77 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
76 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/cargo-config2 that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/const_fn that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/coverage-helper that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/dependabot-config that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/derive_utils that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/target-spec-json that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/syn-serde that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/syn-mid that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/target-spec-json that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/semihosting that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/pin-project that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/pin-project-lite that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/auto_enums that referenced this issue May 24, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
   --> Cargo.toml:118:1
    |
118 | rust_2018_idioms = "warn"
    | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
119 | single_use_lifetimes = "warn"
    | -------------------- has the same priority as this lint
    |
    = note: the order of the lints in the table is ignored by Cargo
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
    = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
    |
118 | rust_2018_idioms = { level = "warn", priority = -1 }
    |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
   --> Cargo.toml:123:1
    |
123 | all = "warn" # Downgrade deny-by-default lints
    | ^^^   ------ has an implicit priority of 0
124 | pedantic = "warn"
125 | as_ptr_cast_mut = "warn"
    | --------------- has the same priority as this lint
    |
    = note: the order of the lints in the table is ignored by Cargo
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
    |
123 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
    |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
   --> Cargo.toml:124:1
    |
124 | pedantic = "warn"
    | ^^^^^^^^   ------ has an implicit priority of 0
125 | as_ptr_cast_mut = "warn"
    | --------------- has the same priority as this lint
    |
    = note: the order of the lints in the table is ignored by Cargo
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
    |
124 | pedantic = { level = "warn", priority = -1 }
    |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
taiki-e added a commit to taiki-e/easy-ext that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/easytime that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/find-crate that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/futures-async-stream that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/futures-enum that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/io-enum that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/iter-enum that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/negative-impl that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/parse-changelog that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/pin-project-lite that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/pin-project that referenced this issue May 24, 2024
taiki-e added a commit to taiki-e/cargo-hack that referenced this issue May 25, 2024
taiki-e added a commit to taiki-e/cargo-no-dev-deps that referenced this issue May 25, 2024
taiki-e added a commit to taiki-e/cargo-minimal-versions that referenced this issue May 25, 2024
taiki-e added a commit to taiki-e/cargo-llvm-cov that referenced this issue May 25, 2024
taiki-e added a commit to taiki-e/atomic-maybe-uninit that referenced this issue May 25, 2024
rust-lang/rust-clippy#12270

```
error: lint group `rust_2018_idioms` has the same priority (0) as a lint
  --> Cargo.toml:50:1
   |
50 | rust_2018_idioms = "warn"
   | ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
51 | single_use_lifetimes = "warn"
   | -------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `rust_2018_idioms` to a lower priority
   |
50 | rust_2018_idioms = { level = "warn", priority = -1 }
   |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:55:1
   |
55 | all = "warn" # Downgrade deny-by-default lints
   | ^^^   ------ has an implicit priority of 0
56 | pedantic = "warn"
57 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `all` to a lower priority
   |
55 | all = { level = "warn", priority = -1 } # Downgrade deny-by-default lints
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:56:1
   |
56 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
57 | as_ptr_cast_mut = "warn"
   | --------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
56 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
SifraiTeam pushed a commit to grandinetech/grandine that referenced this issue May 25, 2024
Cargo.lock was updated to version 4 manually.
All Git refs in our Cargo.lock appear to be encoded correctly.
See:
- rust-lang/cargo#12280
- rust-lang/cargo#12852

The clippy::incompatible_msrv lint may be useful in the future.
We currently do not specify rust-version in Cargo.toml.
Our libraries are not designed to be used outside Grandine.
rust-toolchain.toml makes rust-version redundant for builds inside this repository.
See:
- https://doc.rust-lang.org/1.78.0/cargo/reference/manifest.html#the-rust-version-field
- https://rust-lang.github.io/rust-clippy/rust-1.78.0/#/incompatible_msrv

The clippy::lint_groups_priority lint produces false positives:
- rust-lang/cargo#12918 (comment)
- rust-lang/rust-clippy#12270
Luckily, lints inherited from a workspace do not trigger it.
The issue appears to be fixed in rust-lang/rust-clippy#12827.

The reason public functions trigger clippy::single_call_fn is actually our setting of avoid-breaking-exported-api.
We assumed it was a bug.
taiki-e added a commit to taiki-e/portable-atomic that referenced this issue Jun 1, 2024
taiki-e added a commit to taiki-e/portable-atomic that referenced this issue Jun 1, 2024
@bors bors closed this as completed in 4e7f974 Jun 6, 2024
Luflosi pushed a commit to Luflosi/dyndnsd that referenced this issue Jun 17, 2024
Also allow a new license from one of the dependencies and add a workaround for rust-lang/rust-clippy#12270.
Luflosi pushed a commit to Luflosi/zonegen that referenced this issue Jun 17, 2024
Also allow a new license from one of the dependencies and add a workaround for rust-lang/rust-clippy#12270.
Luflosi pushed a commit to Luflosi/zonewatch that referenced this issue Jun 24, 2024
SifraiTeam pushed a commit to grandinetech/grandine that referenced this issue Jul 12, 2024
Cargo.lock was updated to version 4 manually.
All Git refs in our Cargo.lock appear to be encoded correctly.
See:
- rust-lang/cargo#12280
- rust-lang/cargo#12852

The clippy::incompatible_msrv lint may be useful in the future.
We currently do not specify rust-version in Cargo.toml.
Our libraries are not designed to be used outside Grandine.
rust-toolchain.toml makes rust-version redundant for builds inside this repository.
See:
- https://doc.rust-lang.org/1.78.0/cargo/reference/manifest.html#the-rust-version-field
- https://rust-lang.github.io/rust-clippy/rust-1.78.0/#/incompatible_msrv

The clippy::lint_groups_priority lint produces false positives:
- rust-lang/cargo#12918 (comment)
- rust-lang/rust-clippy#12270
Luckily, lints inherited from a workspace do not trigger it.
The issue appears to be fixed in rust-lang/rust-clippy#12827.

The reason public functions trigger clippy::single_call_fn is actually our setting of avoid-breaking-exported-api.
We assumed it was a bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant