Pass correct substs to implements_trait in incorrect_impls
#11122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Copy<T>` does in fact not exist. The substs on the trait_ref contain the `Self` type of the impl as the first parameter, so passing that to `implements_trait`, which then nicely prepends the `Self` type for us does not end will.
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Noratrieb
commented
Jul 7, 2023
| @@ -80,9 +76,9 @@ impl LateLintPass<'_> for IncorrectImpls { | |||
| && let Some(copy_def_id) = cx.tcx.get_diagnostic_item(sym::Copy) | |||
| && implements_trait( | |||
| cx, | |||
| hir_ty_to_ty(cx.tcx, imp.self_ty), | |||
| trait_impl.self_ty(), | |||
There was a problem hiding this comment.
I also removed a needless hir_ty_to_ty here.
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
xFrednet
added
the
beta-nominated
This was referenced Jul 7, 2023
|
Does not need a backport: The fix that was merged in the Rust repo directly already made it to beta. The only difference is, that the version on beta still uses the |
flip1995
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy<T>does in fact not exist. The substs on the trait_ref contain theSelftype of the impl as the first parameter, so passing that toimplements_trait, which then nicely prepends theSelftype for us does not end will.fixes #11121
The assertions requires debug assertions inside rustc, which is probably why it didn't fire here. I tested the change locally in rust-lang/rust and it did not ICE anymore.
cc @xFrednet @Centri3
changelog: [
incorrect_impls]: fix confusion about generic parameters