[single_match, single_match_else] fix suggestion when match irrefutable
#13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
WeiTheShinobi
force-pushed
the
single_match
branch
2 times, most recently
from
de07605
to
77c92fa
Compare
WeiTheShinobi
force-pushed
the
single_match
branch
from
77c92fa
to
04d70d0
Compare
dswij
reviewed
Sep 1, 2024
tests/ui/single_match.fixed
Outdated
Comment on lines
307
to
309
| { println!() } | ||
|
|
||
| { println!() } |
There was a problem hiding this comment.
Can we suggest this into an expr instead of a block?
For L313, I guess it might change the behaviour if we move out of the block, but this part is fine.
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13012
changelog:[
single_match,single_match_else]: fix suggestion whenmatchirrefutable