too_long_first_doc_paragraph considers rendered output link
#13363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
alex-semenyuk
force-pushed
the
too_long_first_paragraph_fix
branch
from
1067124
to
70cb0d0
Compare
Alexendoo
reviewed
Sep 10, 2024
Comment on lines
+849
to
+851
| let paragraph_string: String = doc[paragraph_range.clone()].chars().collect(); | ||
| let markdown_without_links = replace_markdown_links(¶graph_string); | ||
| headers.first_paragraph_len = markdown_without_links.len(); |
There was a problem hiding this comment.
Since we're in the context of a markdown parser we should aim to use that rather than ad hoc processing, possibly by moving the first_paragraph_len part into the Text event as a +=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13315
As mentioned at #13315 the raw markdown for the link foo contains 13 bytes, but the rendered output is only 3 bytes. This leads to warnings about short paragraphs with long links.
changelog: [
too_long_first_doc_paragraph]: considers rendered output link